Overload the linkTypes method to add the var-args approach #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinst
reviewed
Jun 7, 2025
| * @param linkTypes the link types that should be extracted (by default, all types are extracted) | ||
| * @return this builder | ||
| */ | ||
| public Builder linkTypes(LinkType...linkTypes) { |
There was a problem hiding this comment.
Formatting:
Suggested change
| public Builder linkTypes(LinkType...linkTypes) { | |
| public Builder linkTypes(LinkType... linkTypes) { |
|
Fixed. BTW can I send you a PR making |
That would be an API break, unless you'd want to add a pair of new methods (which I wouldn't want).. Maybe just add some documentation, e.g. in the Javadoc: * If you want a stream, use StreamSupport.stream(extractor.extractLinks(input).spliterator(), false)And add an example in the README? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I overloaded the method to avoid users having to directly use the
Setstatic method.