Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename FEAT capability MLSD -> MLST #1636

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

FanDjango
Copy link
Collaborator

See #1635

The capability should be called MLST in the code and not MLSD. Global rename needed.

@robinrodricks
Copy link
Owner

It looks ok, but it was my understanding that FTP servers can use MLSD and/or MLST?

@FanDjango
Copy link
Collaborator Author

FanDjango commented Aug 21, 2024

it was my understanding that FTP servers can use MLSD and/or MLST?

The operative word, I suppose, is "was". FTP servers should not but sometimes do.

In the RFC, it is written: Either both, or none of them. The availability of both is advertised with MLST. An advertisement MLSD does not exist.

But as one can see, some FTP servers ignore the RFC and advertise only MLSD. Some of them then support only MLSD. Some of them support both commands.

This PR changes only the name MLSD to MLST. It does not change the current logic of allowing both MLST and MLSD advertisements to set the enum "MLST" to true.

It still leaves the decision open, to

  1. Adhere to the RFC.

This will hamper all none RFC compliant servers in different ways, depending on their deviation.

  1. Consider MLST and MLSD advertisements to be synonymous. This is the current implementation, even with this PR applied.

  2. Fix Response: 500 MLST command not understood [Axway Server] #1635 by considering a MLSD advertisement to mean: MLSD command (but not MLST) is supported. This will break an unkown number of servers that need "MLST and MLSD advertisements to be synonymous" (2 above).

Advice?

@robinrodricks
Copy link
Owner

I think this should cover it: - #1635 (comment)

@FanDjango
Copy link
Collaborator Author

Yes. It does.

@FanDjango FanDjango merged commit 6643cd7 into robinrodricks:master Aug 24, 2024
1 check passed
@FanDjango FanDjango deleted the RenameMLSD branch August 25, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants