Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stop job action #131

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

cshintov
Copy link
Contributor

@cshintov cshintov commented Feb 7, 2024

Adds Stop and Purge

Issue #120

Copy link
Owner

@robinovitch61 robinovitch61 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Left a few comments

@cshintov cshintov force-pushed the issue-120-add-stop-job branch from f9151d2 to c4f4bf5 Compare February 9, 2024 10:19
@cshintov cshintov force-pushed the issue-120-add-stop-job branch from c4f4bf5 to 5c0b23f Compare February 9, 2024 10:53
@cshintov
Copy link
Contributor Author

cshintov commented Feb 9, 2024

Made the changes, and fixed a bug too, without the namespace the deregister(stop) call won't work.

So it was only working when started with -n default! Now it works even without it.

@robinovitch61
Copy link
Owner

NBD, but it helps me review easier if you push additional commits after reviews rather than force push :)

Copy link
Owner

@robinovitch61 robinovitch61 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@robinovitch61 robinovitch61 merged commit a333db0 into robinovitch61:next Feb 11, 2024
1 check passed
@cshintov
Copy link
Contributor Author

NBD, but it helps me review easier if you push additional commits after reviews rather than force push :)

Will keep that in mind next time. Btw, what's NBD?

@robinovitch61
Copy link
Owner

No Big Deal, or "doesn't matter so much" :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants