-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stop job action #131
Add stop job action #131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good! Left a few comments
f9151d2
to
c4f4bf5
Compare
Also can purge Issue robinovitch61#120
c4f4bf5
to
5c0b23f
Compare
Made the changes, and fixed a bug too, without the namespace the deregister(stop) call won't work. So it was only working when started with |
NBD, but it helps me review easier if you push additional commits after reviews rather than force push :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Will keep that in mind next time. Btw, what's NBD? |
No Big Deal, or "doesn't matter so much" :) |
Adds Stop and Purge
Issue #120