[fix] Print help for exec when no args are provided

robinovitch61 · Jun 18, 2024 · 6a4ca15 · 6a4ca15
1 parent 02551ed
commit 6a4ca15
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/cmd/exec.go b/cmd/exec.go
@@ -32,6 +32,17 @@ var (
 )
 
 func execEntrypoint(cmd *cobra.Command, args []string) {
+	if len(args) == 0 {
+		cmd.Help()
+		os.Exit(0)
+	}
+
+	allocID := args[0]
+	execArgs := args[1:]
+	if len(execArgs) == 0 {
+		fmt.Println(fmt.Errorf("no command specified"))
+		os.Exit(1)
+	}
 	task := cmd.Flags().Lookup("task").Value.String()
 	// can ignore storing rootOpts here as exec just needs a client
 	config := getConfig(cmd, []string{}, "")
@@ -40,12 +51,7 @@ func execEntrypoint(cmd *cobra.Command, args []string) {
 		fmt.Println(fmt.Errorf("could not get client: %v", err))
 		os.Exit(1)
 	}
-	allocID := args[0]
-	execArgs := args[1:]
-	if len(execArgs) == 0 {
-		fmt.Println("no command specified")
-		os.Exit(1)
-	}
+
 	_, err = nomad.AllocExec(client, allocID, task, execArgs)
 	if err != nil {
 		fmt.Println(fmt.Errorf("could not exec into task: %v", err))