feat: Add Mid and East Antrim Council #428
Conversation
initial commit for mid and east antrim bin collection data
update extraction of date from html
first cut following offline test
remove contents
…oroughCouncil wrong file type
Add Mid and East Antrim
Add Mid and East Antrim
remove paon line as only use postcode but it needs to contain the address
Could you push an extra commit with the 'feat:' in, please? Otherwise happy to merge 😁 |
PhilDB-cloud
changed the title
|
@dp247 Thanks for reviewing. I have attempted to commit with 'feat:' in. Please let me know if I need to do it differently. I'm not very well versed in colaborating in git. |
|
@OliverCullimore : Does the full commit history need every commit message to have the conventional commit prefix? |
|
@PhilDB-cloud in the mean time while Oliver looks into the previous commit history being effected by the pipeline can you try
Be careful to only edit the commit history of your commit - just add feat: before each and I think you should be good Dont change the |
|
@robbrad for neatness of the release changelog and for the lint action to pass every commit in the PR is supposed to have a prefix. But as long as one commit has a correct prefix the automated releases will work so you can ignore the lint action and merge if you like. |
|
thanks all. I should have some time tonight to look at rebasing it. |
|
I was thinking I would just close this pull request and delete the branch and then start again. It seems less risky and won't take me long to do. Does that sound ok? |
|
Entirely your call, I'm more than happy to merge this as is |
|
It seems like it will keep things neater so happy enough to do it. |
feat: Add integration for Mid and East Antrim Borough Council. I have tested it stand alone and I have run the poetry test script for it and it passes. Happy for you to make any suggestions and I can follow up or for you to make edits directly. The website is not particularly easy to scrape. Doesn't use postcode or uprn so ends up with multiple matches for most addresses searched.