feat: Add Herefordshire Council (closes: #1023) #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm sure there's probably room for improvement here. Still figuring out BS4 and Python so there might be a better way to grab the dates.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1198 +/- ##
=======================================
Coverage 71.93% 71.93%
=======================================
Files 9 9
Lines 1037 1037
=======================================
Hits 746 746
Misses 291 291 ☔ View full report in Codecov by Sentry. |
|
Sorry, this actually closes: #1023 , I blame lack of caffeine and sleep 😴 |
geekball
changed the title
robbrad
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sure there's probably room for improvement here. Still figuring out BS4 and Python so there might be a better way to grab the dates. Not sure if raising exceptions/errors is acceptable but figured it was nicer than crashing out in the for loop.