-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reference sorting #81
Draft
matiassingers
wants to merge
9
commits into
roam-unofficial:master
Choose a base branch
from
matiassingers:reference-sorting
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add reference sorting #81
matiassingers
wants to merge
9
commits into
roam-unofficial:master
from
matiassingers:reference-sorting
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
would be nice to support queries too :) |
TODO: figure out how to handle page navigations TODO: allow buttons to act as asc/desc by reversing order and icon TODO: find a better icon for Daily Notes first/last
…code for all new features
…ally) (+1 squashed commit) Squashed commits: [fa3c3ef] TODO: add settings for toggling the various sorting modes (alphabetically)
TODO: fix sorting toggling + refactor
matiassingers
force-pushed
the
reference-sorting
branch
from
June 18, 2020 03:54
00da73d
to
da540c2
Compare
@matiassingers Just fyi @tntmarket has already created the abstraction to wait for selector on top of mutation observe (that's the same use-case you have if I understand correctly) @tntmarket can you create a PR to push that part as it'd be useful here and in #83 |
Opened up a PR here: #93 The helpers will be in |
Thanks, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a super hacky proof-of-concept, but I wanted to get some feedback on the direction before investing too much time into it.
Features being added:
TODOs
I've tried pointing out all the pending TODO items in code comments, but just capturing the major ones here as well:
Class
Clean-up
Example
(it was super fun getting back into a bit of JavaScript again, and using TypeScript for the first time)