-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release/v2024.3.2 #198
release/v2024.3.2 #198
Conversation
Signed-off-by: Valery Piashchynski <[email protected]>
WalkthroughThis pull request involves comprehensive version updates for multiple RoadRunner server plugins and components in the Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
velox.toml
(2 hunks)
🧰 Additional context used
🪛 GitHub Actions: Linux
velox.toml
[error] Failed to download repository template: GET https://codeload.github.com/roadrunner-server/roadrunner/legacy.zip/v2024.3.2 returned 404 Not Found
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (go)
🔇 Additional comments (8)
velox.toml (8)
16-19
: LGTM: Consistent version updates for logging pluginsAll logging-related plugins have been consistently updated to v5.1.2.
🧰 Tools
🪛 GitHub Actions: Linux
[error] Failed to download repository template: GET https://codeload.github.com/roadrunner-server/roadrunner/legacy.zip/v2024.3.2 returned 404 Not Found
22-22
: LGTM: Centrifuge plugin version alignedThe Centrifuge plugin version has been updated to match the common v5.1.2 version.
🧰 Tools
🪛 GitHub Actions: Linux
[error] Failed to download repository template: GET https://codeload.github.com/roadrunner-server/roadrunner/legacy.zip/v2024.3.2 returned 404 Not Found
49-55
: LGTM: Consistent version updates for jobs pluginsAll jobs and messaging plugins have been consistently updated to v5.1.2.
🧰 Tools
🪛 GitHub Actions: Linux
[error] Failed to download repository template: GET https://codeload.github.com/roadrunner-server/roadrunner/legacy.zip/v2024.3.2 returned 404 Not Found
25-25
: Verify breaking changes in Temporal v5.4.0The Temporal plugin has a significant version jump from v5.1.1 to v5.4.0. Please verify the changelog for any breaking changes.
✅ Verification successful
✅ Temporal v5.4.0 update appears safe
The changelog shows only bug fixes, minor dependency updates, and new optional features without any breaking changes or deprecations.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check Temporal plugin changelog gh api repos/temporalio/roadrunner-temporal/releases --paginate | jq -r '.[] | select(.tag_name=="v5.4.0") | .body'Length of output: 1128
🧰 Tools
🪛 GitHub Actions: Linux
[error] Failed to download repository template: GET https://codeload.github.com/roadrunner-server/roadrunner/legacy.zip/v2024.3.2 returned 404 Not Found
28-31
: Verify documentation for new OpenTelemetry pluginA new OpenTelemetry plugin has been added. Please ensure that documentation is available for this new feature.
🧰 Tools
🪛 GitHub Actions: Linux
[error] Failed to download repository template: GET https://codeload.github.com/roadrunner-server/roadrunner/legacy.zip/v2024.3.2 returned 404 Not Found
43-46
: Verify compatibility with server v5.2.3The server plugin (v5.2.3) is at a higher version than most other plugins (v5.1.2). Please verify compatibility between these versions.
✅ Verification successful
Server v5.2.3 and service v5.1.2 are compatible
The versions are compatible as they:
- Share the same major version (v5)
- Follow the documented compatibility requirements
- Have no breaking changes between versions
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check server plugin compatibility requirements gh api repos/roadrunner-server/server/contents/go.mod | jq -r '.content' | base64 -d | grep roadrunner-serverLength of output: 206
Script:
#!/bin/bash # Check release notes and documentation for compatibility information gh api repos/roadrunner-server/server/releases | jq -r '.[] | select(.tag_name=="v5.2.3" or .tag_name=="v5.2.2" or .tag_name=="v5.2.1" or .tag_name=="v5.2.0") | "Version: \(.tag_name)\n\(.body)\n"' # Also check the main documentation rg -i "version|compatibility" README.mdLength of output: 1936
🧰 Tools
🪛 GitHub Actions: Linux
[error] Failed to download repository template: GET https://codeload.github.com/roadrunner-server/roadrunner/legacy.zip/v2024.3.2 returned 404 Not Found
34-40
: Consider aligning HTTP stack versionsThe HTTP stack shows slight version inconsistencies:
- http: v5.2.1
- static, send: v5.1.1
- others: v5.1.2
Consider if these versions should be aligned or if there are specific reasons for the differences.
🧰 Tools
🪛 GitHub Actions: Linux
[error] Failed to download repository template: GET https://codeload.github.com/roadrunner-server/roadrunner/legacy.zip/v2024.3.2 returned 404 Not Found
58-74
: Verify KV stack version differencesThe KV stack shows version differences:
- kv, memory: v5.2.2
- Other KV plugins: v5.1.2
Please verify if these version differences are intentional and if there are any compatibility requirements.
🧰 Tools
🪛 GitHub Actions: Linux
[error] Failed to download repository template: GET https://codeload.github.com/roadrunner-server/roadrunner/legacy.zip/v2024.3.2 returned 404 Not Found
@@ -1,6 +1,6 @@ | |||
[roadrunner] | |||
# ref -> reference, tag, commit or branch | |||
ref = "v2024.3.1" | |||
ref = "v2024.3.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Use v2024.3.1 instead of non-existent v2024.3.2
The version v2024.3.2
has not been released yet. The latest available version is v2024.3.1
. Please update the version reference to use the latest stable release.
🔗 Analysis chain
Critical: Version v2024.3.2 is not available
The pipeline is failing because the specified RoadRunner version v2024.3.2
cannot be found. The 404 error suggests this version has not been released yet or the tag is incorrect.
Let's verify the available versions:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check available RoadRunner versions
# Get the latest releases and tags
gh api repos/roadrunner-server/roadrunner/releases --paginate | jq -r '.[].tag_name'
Length of output: 1618
🧰 Tools
🪛 GitHub Actions: Linux
[error] Failed to download repository template: GET https://codeload.github.com/roadrunner-server/roadrunner/legacy.zip/v2024.3.2 returned 404 Not Found
Reason for This PR
Stable release cycle.
Description of Changes
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]
git commit -s
).CHANGELOG.md
.Summary by CodeRabbit
v5.0.x
tov5.1.x
andv5.2.x
v2024.3.1
tov2024.3.2