Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/v2024.3.2 #198

Merged
merged 1 commit into from
Jan 16, 2025
Merged

release/v2024.3.2 #198

merged 1 commit into from
Jan 16, 2025

Conversation

rustatian
Copy link
Member

@rustatian rustatian commented Jan 16, 2025

Reason for This PR

Stable release cycle.

Description of Changes

  • Update plugins in the velox.toml configuration.
  • Update RR to v2024.3.2

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Summary by CodeRabbit

  • Chores
    • Updated RoadRunner dependencies and plugins to latest versions
    • Upgraded multiple plugins from v5.0.x to v5.1.x and v5.2.x
    • Added new OpenTelemetry (OTEL) plugin
    • Updated RoadRunner core version from v2024.3.1 to v2024.3.2

Signed-off-by: Valery Piashchynski <[email protected]>
@rustatian rustatian added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label Jan 16, 2025
@rustatian rustatian requested a review from wolfy-j January 16, 2025 19:43
@rustatian rustatian self-assigned this Jan 16, 2025
Copy link

coderabbitai bot commented Jan 16, 2025

Walkthrough

This pull request involves comprehensive version updates for multiple RoadRunner server plugins and components in the velox.toml configuration file. The changes primarily focus on incrementing version references across various GitHub plugins, with most plugins being updated from versions around v5.0.x to v5.1.2. Notable updates include the temporal plugin jumping from v5.1.1 to v5.4.0, the server plugin updating from v5.1.2 to v5.2.3, and the addition of a new otel plugin.

Changes

File Changes
velox.toml - Updated RoadRunner version from v2024.3.1 to v2024.3.2
- Updated most plugin versions to v5.1.2
- Added new otel plugin with version v5.1.2
- Specific notable updates: temporal to v5.4.0, server to v5.2.3, http to v5.2.1

Possibly related PRs

  • release: v2024.1.4 #162: Updates version references in a similar configuration file, suggesting a coordinated version upgrade process

Poem

🐰 Hop, hop, versions dance and leap,
Config files now sparkle and keep
Plugins updated with gentle grace
RoadRunner plugins find their new space
A version waltz, precise and neat! 🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 763d857 and a601774.

📒 Files selected for processing (1)
  • velox.toml (2 hunks)
🧰 Additional context used
🪛 GitHub Actions: Linux
velox.toml

[error] Failed to download repository template: GET https://codeload.github.com/roadrunner-server/roadrunner/legacy.zip/v2024.3.2 returned 404 Not Found

⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyze (go)
🔇 Additional comments (8)
velox.toml (8)

16-19: LGTM: Consistent version updates for logging plugins

All logging-related plugins have been consistently updated to v5.1.2.

🧰 Tools
🪛 GitHub Actions: Linux

[error] Failed to download repository template: GET https://codeload.github.com/roadrunner-server/roadrunner/legacy.zip/v2024.3.2 returned 404 Not Found


22-22: LGTM: Centrifuge plugin version aligned

The Centrifuge plugin version has been updated to match the common v5.1.2 version.

🧰 Tools
🪛 GitHub Actions: Linux

[error] Failed to download repository template: GET https://codeload.github.com/roadrunner-server/roadrunner/legacy.zip/v2024.3.2 returned 404 Not Found


49-55: LGTM: Consistent version updates for jobs plugins

All jobs and messaging plugins have been consistently updated to v5.1.2.

🧰 Tools
🪛 GitHub Actions: Linux

[error] Failed to download repository template: GET https://codeload.github.com/roadrunner-server/roadrunner/legacy.zip/v2024.3.2 returned 404 Not Found


25-25: Verify breaking changes in Temporal v5.4.0

The Temporal plugin has a significant version jump from v5.1.1 to v5.4.0. Please verify the changelog for any breaking changes.

✅ Verification successful

✅ Temporal v5.4.0 update appears safe

The changelog shows only bug fixes, minor dependency updates, and new optional features without any breaking changes or deprecations.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check Temporal plugin changelog
gh api repos/temporalio/roadrunner-temporal/releases --paginate | jq -r '.[] | select(.tag_name=="v5.4.0") | .body'

Length of output: 1128

🧰 Tools
🪛 GitHub Actions: Linux

[error] Failed to download repository template: GET https://codeload.github.com/roadrunner-server/roadrunner/legacy.zip/v2024.3.2 returned 404 Not Found


28-31: Verify documentation for new OpenTelemetry plugin

A new OpenTelemetry plugin has been added. Please ensure that documentation is available for this new feature.

🧰 Tools
🪛 GitHub Actions: Linux

[error] Failed to download repository template: GET https://codeload.github.com/roadrunner-server/roadrunner/legacy.zip/v2024.3.2 returned 404 Not Found


43-46: Verify compatibility with server v5.2.3

The server plugin (v5.2.3) is at a higher version than most other plugins (v5.1.2). Please verify compatibility between these versions.

✅ Verification successful

Server v5.2.3 and service v5.1.2 are compatible

The versions are compatible as they:

  • Share the same major version (v5)
  • Follow the documented compatibility requirements
  • Have no breaking changes between versions
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check server plugin compatibility requirements
gh api repos/roadrunner-server/server/contents/go.mod | jq -r '.content' | base64 -d | grep roadrunner-server

Length of output: 206


Script:

#!/bin/bash
# Check release notes and documentation for compatibility information
gh api repos/roadrunner-server/server/releases | jq -r '.[] | select(.tag_name=="v5.2.3" or .tag_name=="v5.2.2" or .tag_name=="v5.2.1" or .tag_name=="v5.2.0") | "Version: \(.tag_name)\n\(.body)\n"'

# Also check the main documentation
rg -i "version|compatibility" README.md

Length of output: 1936

🧰 Tools
🪛 GitHub Actions: Linux

[error] Failed to download repository template: GET https://codeload.github.com/roadrunner-server/roadrunner/legacy.zip/v2024.3.2 returned 404 Not Found


34-40: Consider aligning HTTP stack versions

The HTTP stack shows slight version inconsistencies:

  • http: v5.2.1
  • static, send: v5.1.1
  • others: v5.1.2

Consider if these versions should be aligned or if there are specific reasons for the differences.

🧰 Tools
🪛 GitHub Actions: Linux

[error] Failed to download repository template: GET https://codeload.github.com/roadrunner-server/roadrunner/legacy.zip/v2024.3.2 returned 404 Not Found


58-74: Verify KV stack version differences

The KV stack shows version differences:

  • kv, memory: v5.2.2
  • Other KV plugins: v5.1.2

Please verify if these version differences are intentional and if there are any compatibility requirements.

🧰 Tools
🪛 GitHub Actions: Linux

[error] Failed to download repository template: GET https://codeload.github.com/roadrunner-server/roadrunner/legacy.zip/v2024.3.2 returned 404 Not Found

@@ -1,6 +1,6 @@
[roadrunner]
# ref -> reference, tag, commit or branch
ref = "v2024.3.1"
ref = "v2024.3.2"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

⚠️ Potential issue

Use v2024.3.1 instead of non-existent v2024.3.2

The version v2024.3.2 has not been released yet. The latest available version is v2024.3.1. Please update the version reference to use the latest stable release.

🔗 Analysis chain

Critical: Version v2024.3.2 is not available

The pipeline is failing because the specified RoadRunner version v2024.3.2 cannot be found. The 404 error suggests this version has not been released yet or the tag is incorrect.

Let's verify the available versions:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check available RoadRunner versions
# Get the latest releases and tags
gh api repos/roadrunner-server/roadrunner/releases --paginate | jq -r '.[].tag_name'

Length of output: 1618

🧰 Tools
🪛 GitHub Actions: Linux

[error] Failed to download repository template: GET https://codeload.github.com/roadrunner-server/roadrunner/legacy.zip/v2024.3.2 returned 404 Not Found

@rustatian rustatian merged commit 58d2ae5 into master Jan 16, 2025
6 of 7 checks passed
@rustatian rustatian deleted the release/v2024.3.2 branch January 16, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant