-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: http health and readiness checks #130
Conversation
Signed-off-by: Valery Piashchynski <[email protected]>
WalkthroughThe recent updates involve the removal of the Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 5
Configuration used: CodeRabbit UI
Files ignored due to filter (5)
- go.mod
- go.sum
- go.work.sum
- tests/go.mod
- tests/go.sum
Files selected for processing (5)
- .golangci.yml (1 hunks)
- status.go (1 hunks)
- tests/configs/.rr-grpc-status.yaml (1 hunks)
- tests/grpc_plugin_gzip_test.go (5 hunks)
- tests/grpc_plugin_test.go (12 hunks)
Additional comments: 13
.golangci.yml (1)
- 53-58: The removal of
goconst
from the linters-settings section is consistent with the summary and pull request overview. However, ensure that thegoconst
linter is also removed from the enabled linters list if it was previously included.tests/configs/.rr-grpc-status.yaml (3)
1-30: The configuration file has been updated with new settings for version '3', including RPC, server, status, and GRPC service configurations. Ensure that these settings are compatible with the rest of the application and that the specified ports are not already in use or blocked by firewalls.
19-20: The
max_send_msg_size
andmax_recv_msg_size
are set to 50, which may be too low for practical use. Verify that this limit is sufficient for the expected message sizes in the application.21-23: The
max_connection_idle
,max_connection_age
, andmax_connection_age_grace
are set to '0s', which might indicate no limit. Confirm that this is the intended behavior, as it could lead to connections never being closed and potentially cause resource leaks.tests/grpc_plugin_gzip_test.go (5)
33-39: The update of the
Version
field in theconfig.Plugin
struct to "2023.3.0" is consistent with the summary provided. This change is likely to align the tests with the new features and ensure compatibility with the updated version of the application.110-116: The update of the
Version
field in theconfig.Plugin
struct to "2023.3.0" is consistent with the summary provided. This change is likely to align the tests with the new features and ensure compatibility with the updated version of the application.204-210: The update of the
Version
field in theconfig.Plugin
struct to "2023.3.0" is consistent with the summary provided. This change is likely to align the tests with the new features and ensure compatibility with the updated version of the application.289-295: The update of the
Version
field in theconfig.Plugin
struct to "2023.3.0" is consistent with the summary provided. This change is likely to align the tests with the new features and ensure compatibility with the updated version of the application.374-380: The update of the
Version
field in theconfig.Plugin
struct to "2023.3.0" is consistent with the summary provided. This change is likely to align the tests with the new features and ensure compatibility with the updated version of the application.tests/grpc_plugin_test.go (4)
25-28: The addition of the
status/v4
import aligns with the introduction of health and readiness endpoints as described in the summary.47-53: The update of the version in the
cfg
struct to "2023.3.0" is consistent with the summary and seems to be a necessary change to align the tests with the new application version.109-215: The version update to "2023.3.0" in the
cfg
struct is consistently applied across all test functions, ensuring compatibility with the new features and application version.25-31: > Note: This review was outside the patches, and no patch overlapping with it was found. Original lines [432-434]
The
TestGrpcFullErrorMessageIssue1193
function still uses the version "2.10.6". If this is intentional for testing backward compatibility or a specific issue, it may be acceptable. Otherwise, consider updating it to "2023.3.0" for consistency.
Reason for This PR
ref: https://github.com/orgs/roadrunner-server/discussions/967
Description of Changes
/health
and/ready
http endpoints.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]
git commit -s
).CHANGELOG.md
.Summary by CodeRabbit
Refactor
goconst
linter to streamline the linting process.New Features
grpc
package to enhance plugin communication capabilities.Status()
andReady()
functions for improved plugin status reporting.Documentation
Tests