Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation links #10

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Fix documentation links #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2be18c
Fix documentation links
msmakouz Feb 7, 2024
13bb24c
Up roadrunner-php/roadrunner-api-dto version, fix test
msmakouz Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/phpunit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
on:
push:
branches:
- master
- '*.*'
Comment on lines 3 to 4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch wildcard pattern '*.*' might not match all branches, especially those without a dot. Consider using '**' to include all branches if that's the intention.

pull_request: null

Expand All @@ -13,7 +12,5 @@ jobs:
with:
os: >-
['ubuntu-latest']
php: >-
['8.1', '8.2']
stability: >-
['prefer-stable']
Comment on lines 12 to 16
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [11-13]

The os configuration is specified as an array but should be a string for a single value. Remove the array notation.

-        ['ubuntu-latest']
+        ubuntu-latest

Comment on lines 14 to 16
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stability configuration is specified as an array but should be a string for a single value. Remove the array notation.

-        ['prefer-stable']
+        prefer-stable
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
['ubuntu-latest']
php: >-
['8.1', '8.2']
stability: >-
['prefer-stable']
['ubuntu-latest']
stability: >-
prefer-stable

3 changes: 0 additions & 3 deletions .github/workflows/psalm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
on:
push:
branches:
- master
- '*.*'
Comment on lines 3 to 4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch wildcard pattern '*.*' might not match all branches, especially those without a dot. Consider using '**' to include all branches if that's the intention.

pull_request: null

Expand All @@ -13,5 +12,3 @@ jobs:
with:
os: >-
['ubuntu-latest']
Comment on lines 12 to 14
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [11-13]

The os configuration is specified as an array but should be a string for a single value. Remove the array notation.

-        ['ubuntu-latest']
+        ubuntu-latest

php: >-
['8.1']
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
[![psalm](https://github.com/spiral/roadrunner-services/actions/workflows/psalm.yml/badge.svg)](https://github.com/spiral/roadrunner-services/actions)
[![Total Downloads](https://poser.pugx.org/spiral/roadrunner-services/downloads)](https://packagist.org/packages/spiral/roadrunner-services)

This package will help you to manage [Roadrunner services](https://roadrunner.dev/docs/plugins-service)
This package will help you to manage [Roadrunner services](https://docs.roadrunner.dev/plugins/service)

## Requirements

Expand Down
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
],
"homepage": "https://roadrunner.dev/",
"support": {
"docs": "https://roadrunner.dev/docs",
"docs": "https://docs.roadrunner.dev",
"issues": "https://github.com/roadrunner-server/roadrunner/issues",
"forum": "https://forum.roadrunner.dev/",
"chat": "https://discord.gg/V6EK4he"
Expand All @@ -36,7 +36,7 @@
],
"require": {
"php": ">=8.1",
"roadrunner-php/roadrunner-api-dto": "^1.1",
"roadrunner-php/roadrunner-api-dto": "^1.4",
"spiral/roadrunner": "^2023.2",
"spiral/goridge": "^4.0",
"google/protobuf": "^3.7"
Expand Down
2 changes: 1 addition & 1 deletion src/Manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public function list(): array
* @param bool $serviceNameInLogs Show the name of the service in logs (e.g. service.some_service_1).
* @param int<0, max> $stopTimeout Timeout for the process stop operation.
* @throws Exception\ServiceException
* @see https://roadrunner.dev/docs/beep-beep-service
* @see https://docs.roadrunner.dev/plugins/service
*/
public function create(
string $name,
Expand Down
2 changes: 1 addition & 1 deletion tests/ManagerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ public function testServiceStatusesShouldBeReturned(): void
'pid' => 33,
'memory_usage' => 200,
'command' => 'foo/bar',
'status' => new \RoadRunner\Shared\DTO\V1\Status([
'status' => new \RoadRunner\Common\DTO\V1\Status([
'code' => 100,
'message' => 'Running',
'details' => [
Expand Down
Loading