Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM PoC for gradual removal of Langchain #373

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpodivin
Copy link
Contributor

@jpodivin jpodivin commented Feb 10, 2025

Description

The PR is not meant to be merged, it is only meant to demonstrate how we could gradually remove Langchain API from the code. The PromptTemplate can be replaced with simple replace call on a string object. The chain itself can be replaced with a bare LLM model.

This still involves Langchain during the model call, but it doesn't involve as many abstractions. Further improvement would be to replace LLM object from Langhchain with a simple wrapper for REST API calls.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@tisnik
Copy link
Collaborator

tisnik commented Feb 10, 2025

@asamal4 FYI this is what we talked about (not anything we have to solve now, you know)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants