Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OLS-39: Streaming endpoint #279

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Conversation

onmete
Copy link
Contributor

@onmete onmete commented Jan 16, 2025

Description

Implement streaming endpoint

Type of change

  • Refactor
  • New feature

@onmete onmete force-pushed the streaming-endpoint branch from 8c65026 to b0082c1 Compare January 16, 2025 09:25
@tisnik
Copy link
Collaborator

tisnik commented Jan 16, 2025

Why is pyaml added as direct dependency?

@onmete
Copy link
Contributor Author

onmete commented Jan 16, 2025

I still got an error after make install-deps and make install-deps-test.

@tisnik
Copy link
Collaborator

tisnik commented Jan 16, 2025

I still got an error after make install-deps and make install-deps-test.

then we need to investigate why it is problem now and not before (nor in downstream repo)

@onmete onmete force-pushed the streaming-endpoint branch from b0082c1 to 3c1da26 Compare January 16, 2025 09:55
@onmete
Copy link
Contributor Author

onmete commented Jan 16, 2025

I've removed that commit. My mistake was that I got confused about what terminal window I was in (I blame the actual repo being called just service).

@onmete onmete force-pushed the streaming-endpoint branch from 3c1da26 to d06de5e Compare January 16, 2025 10:06
Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks ok

@tisnik tisnik merged commit a3b0b05 into road-core:main Jan 16, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants