Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

woke linter made it impossible to commit any work #278

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

jpodivin
Copy link
Contributor

@jpodivin jpodivin commented Jan 15, 2025

Description

Woke is getting triggered by existing contents of the repo. This prevents creation of any new commits, unless you disable the check entirely.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Comment on lines 116 to 117
severity: error No newline at end of file
severity: error
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another linter was triggered by this.

@tisnik tisnik merged commit 3f423f6 into road-core:main Jan 15, 2025
9 checks passed
@jpodivin jpodivin deleted the control branch January 16, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants