Skip to content

Refactor pgp_fingerprint_t and pgp_keyid_t. #2331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 31, 2025
Merged

Conversation

ni4
Copy link
Contributor

@ni4 ni4 commented Mar 24, 2025

Fixes #2110

@ni4 ni4 marked this pull request as draft March 24, 2025 10:57
@ni4 ni4 force-pushed the ni4-2110-refactor-fingerprint branch from 6ef01e6 to fa375d7 Compare March 24, 2025 11:01
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 92.80000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 85.27%. Comparing base (6a01b03) to head (56d39c1).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/fingerprint.cpp 89.65% 3 Missing ⚠️
src/librepgp/stream-dump.cpp 82.35% 3 Missing ⚠️
src/lib/key.cpp 92.00% 2 Missing ⚠️
src/librekey/key_store_pgp.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2331      +/-   ##
==========================================
+ Coverage   85.23%   85.27%   +0.03%     
==========================================
  Files         124      125       +1     
  Lines       22858    22813      -45     
==========================================
- Hits        19484    19453      -31     
+ Misses       3374     3360      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ni4 ni4 force-pushed the ni4-2110-refactor-fingerprint branch 5 times, most recently from 5eb6e4e to f607d4f Compare March 25, 2025 13:00
@ni4 ni4 force-pushed the ni4-2110-refactor-fingerprint branch from f607d4f to 56d39c1 Compare March 26, 2025 12:05
@ni4 ni4 marked this pull request as ready for review March 26, 2025 13:11
@ni4 ni4 requested review from ronaldtse, maxirmx and desvxx March 26, 2025 16:02
Copy link
Member

@maxirmx maxirmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ni4
Copy link
Contributor Author

ni4 commented Mar 31, 2025

Merging with two approvals. Thanks!

@ni4 ni4 merged commit ccbd02e into main Mar 31, 2025
122 checks passed
@ni4 ni4 deleted the ni4-2110-refactor-fingerprint branch March 31, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor keyid/fingerprint calculation.
3 participants