-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GraphQL::Query::Partial #5183
base: master
Are you sure you want to change the base?
Conversation
@@ -53,9 +53,6 @@ def initialize(query:, schema: query.schema, values:) | |||
@storage = Hash.new { |h, k| h[k] = {} } | |||
@storage[nil] = @provided_values | |||
@errors = [] | |||
@path = [] | |||
@value = nil | |||
@context = self # for SharedMethods TODO delete sharedmethods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were leftover from a previous GraphQL::Query::Context
implementation. I rediscovered them while working on this feature because at first, I thought I was going to need to use query.context.dup
. I didn't end up doing that (instead, Query::Context.new
inside Partial#initialize
) but I'm going to keep these clean-ups.
This is to implement partial execution, where you can take a prepared
GraphQL::Query
and run part of it in isolation.Fixes #5136
TODO