Fix bug in DataLoader::Source#load_all when sending only falsy values #5167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ruby: ```rb [nil].any? #=> false [false].any? #=> false ``` When sending [nil] to load_all, it was making the source think that there are no pending keys, and raised GraphQL::InvariantError. ## To finalize your edit, press ctrl+Enter. To cancel, close the view.
Baxxx
force-pushed
the
fix_load_all_for_nils
branch
from
4573411 to
cc2fbb7
Compare
rmosolgo
reviewed
Nov 21, 2024
|
Thanks for this fix! I have a Rubocop rule that checks for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ruby:
When sending [nil] to load_all, it was making the source think that there are no pending keys, and raised GraphQL::InvariantError.