Support calls to write_subscription within resolve #5142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change, you can directly call
#write_subscription
from insidedef subscribe
to tell your subscription backend to register the current event. This is helpful for ensuring the right sequence of steps during subscribe and update.Part of #5138
I originally considered detecting errors and calling
delete_subscription
in that case, but I decided against it because:Technically speaking, even if the initial subscription encounters an error, later updates could still succeed. (They will have access to different data, different system status, etc.)
TODO