Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support calls to write_subscription within resolve #5142

Merged
merged 7 commits into from
Dec 9, 2024

Conversation

rmosolgo
Copy link
Owner

@rmosolgo rmosolgo commented Nov 4, 2024

After this change, you can directly call #write_subscription from inside def subscribe to tell your subscription backend to register the current event. This is helpful for ensuring the right sequence of steps during subscribe and update.

Part of #5138

I originally considered detecting errors and calling delete_subscription in that case, but I decided against it because:

  • it's not in the spec
  • and, it's not how existing subscriptions work

Technically speaking, even if the initial subscription encounters an error, later updates could still succeed. (They will have access to different data, different system status, etc.)

TODO

  • Consider more edge cases
  • Document

@rmosolgo rmosolgo added this to the 2.4.8 milestone Dec 9, 2024
@rmosolgo rmosolgo merged commit dd24fce into master Dec 9, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant