Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rescue from on loading arguments #3471

Merged
merged 2 commits into from
May 11, 2021

Conversation

rmosolgo
Copy link
Owner

Fixes #3262

Add with_error_handling to a few codepaths that check arguments.

This is really becoming a mess, so many different errors and error handling paths (see also #3459)

rmosolgo added 2 commits May 11, 2021 09:19

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@rmosolgo rmosolgo added this to the 1.12.10 milestone May 11, 2021
@rmosolgo rmosolgo merged commit e81135e into master May 11, 2021
@rmosolgo rmosolgo deleted the fix-rescue-from-on-loading-arguments branch May 11, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rescue_from not being called when failing to load an argument in queries
1 participant