Merge pull request #5152 from rmosolgo/fix-sync-dump-with-outfile

Fix dumping payload with outfile
rmosolgo · Nov 8, 2024 · bf5a03b · bf5a03b
2 parents 777b861 + be65137
commit bf5a03b
Show file tree

Hide file tree

Showing 3 changed files with 56 additions and 0 deletions.
diff --git a/javascript_client/src/__tests__/__snapshots__/syncTest.ts.snap b/javascript_client/src/__tests__/__snapshots__/syncTest.ts.snap
diff --git a/javascript_client/src/__tests__/syncTest.ts b/javascript_client/src/__tests__/syncTest.ts
@@ -296,6 +296,28 @@ describe("sync operations", () => {
       })
     })
 
+    it("Can dump payload and outfile at the same time", () => {
+      var options = {
+        client: "test-2",
+        path: "./src/__tests__/project",
+        quiet: true,
+        outfile: "customOutfile.js",
+        dumpPayload: "customDumpPayload.js"
+      }
+
+      return sync(options).then(function() {
+        var generatedCode = fs.readFileSync("./customOutfile.js", "utf8")
+        expect(generatedCode).toMatch('"GetStuff": "4568c28d403794e011363caf815ec827"')
+        expect(generatedCode).toMatch('module.exports = OperationStoreClient')
+        expect(generatedCode).toMatch('var _client = "test-2"')
+
+        var generatedPayload = fs.readFileSync("./customDumpPayload.js", "utf8")
+        expect(generatedPayload).toMatchSnapshot()
+        fs.unlinkSync("./customOutfile.js")
+        fs.unlinkSync("./customDumpPayload.js")
+      })
+    })
+
     it("Skips outfile generation when using --persist-output artifact", () => {
       var options = {
         client: "test-2",

diff --git a/javascript_client/src/sync/index.ts b/javascript_client/src/sync/index.ts
@@ -221,6 +221,7 @@ function sync(options: SyncOptions) {
       })
     } else if (dumpingPayload) {
       sendFunc(payload, { dumpPayload: options.dumpPayload })
+      resolve(payload)
       return
     } else {
       // This is a local-only run to generate an artifact