Merge pull request #3451 from Shopify/fix-invalid-default

Fix test with invalid default value
rmosolgo · Apr 27, 2021 · 8c981e7 · 8c981e7
2 parents dcaddc8 + e13004a
commit 8c981e7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/spec/graphql/schema/input_object_spec.rb b/spec/graphql/schema/input_object_spec.rb
@@ -487,7 +487,7 @@ def self.resolve_type(type, obj, ctx)
 
     it "works with empty objects" do
       res = Jazz::Schema.execute("{ defaultValueTest2 }")
-      assert_equal "Jazz::InspectableInput -> {}", res["data"]["defaultValueTest2"]
+      assert_equal "Jazz::FullyOptionalInput -> {}", res["data"]["defaultValueTest2"]
     end
 
     it "introspects in GraphQL language with enums" do

diff --git a/spec/support/jazz.rb b/spec/support/jazz.rb
@@ -335,6 +335,10 @@ class LegacyInputType < GraphQL::Schema::InputObject
     argument :int_value, Int, required: true
   end
 
+  class FullyOptionalInput < GraphQL::Schema::InputObject
+    argument :optional_value, String, required: false
+  end
+
   class InspectableInput < GraphQL::Schema::InputObject
     argument :ensemble_id, ID, required: false, loads: Ensemble
     argument :string_value, String, required: true, description: "Test description kwarg"
@@ -547,7 +551,7 @@ def default_value_test(arg_with_default:)
     end
 
     field :default_value_test_2, String, null: false, resolver_method: :default_value_test do
-      argument :arg_with_default, InspectableInput, required: false, default_value: {}
+      argument :arg_with_default, FullyOptionalInput, required: false, default_value: {}
     end
 
     field :complex_hash_key, String, null: false, hash_key: :'foo bar/fizz-buzz'