Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'dispose' action #135

Merged
merged 2 commits into from Aug 1, 2013
Merged

Added 'dispose' action #135

merged 2 commits into from Aug 1, 2013

Conversation

ghost
Copy link

@ghost ghost commented Jun 25, 2013

  • use with elements about to be removed from the DOM or that otherwise
    no longer require updating
  • only clears interval; leaves node as-is
  • usage: $('.timeago').timeago('dispose');

@rmm5t
Copy link
Owner

rmm5t commented Jun 26, 2013

Possible to add tests for this feature?

Dave added 2 commits July 30, 2013 12:25
- use with elements about to be removed from the DOM or that otherwise
no longer require updating
- only clears interval; leaves node as-is
- usage: $('.timeago').timeago('dispose');
@ghost
Copy link
Author

ghost commented Jul 30, 2013

Line endings should be good now.

rmm5t added a commit that referenced this pull request Aug 1, 2013
@rmm5t rmm5t merged commit 61980c6 into rmm5t:master Aug 1, 2013
@rmm5t
Copy link
Owner

rmm5t commented Aug 1, 2013

@enterprisey Thanks! Sorry for the delay on this one. I'll try to get an official release out this week that incorporates this change too.

@philfreo
Copy link

philfreo commented Aug 1, 2013

@rmm5t along the same lines as dispose (not having extra timers, etc. around), can you take a look at #30 which (even when not using jquery-live) or similar so that calling autosave() multiple times (when new portions of the dom are rendered/re-rendered) that multiple instances of autosave don't get instantiated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants