Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split the logllikelihood and its gradient #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zhou13
Copy link

@zhou13 zhou13 commented Dec 26, 2015

See Issues #8.

@zhou13
Copy link
Author

zhou13 commented Dec 26, 2015

Not sure why the checks failed. It seems not related to the tests. It should pass all the nosetests.

@rmcgibbo
Copy link
Owner

Okay, I fixed the travis issues in #10, so if you rebase this PR on the current master, the tests should run.

@zhou13
Copy link
Author

zhou13 commented Dec 28, 2015

I rebased my branch and did a git push --force but it seems that the problem is still there. Could you have a check?

@rmcgibbo
Copy link
Owner

Is there a way that you can make it backwards compatible with the old API? Maybe using the same pattern that the jac argument to scipy.optimize.minimize uses, taking a callable or True? The reason is that for some of my applications, the gradient and objective have so many terms in common that once you've computed the objective, the gradient is basically free (and visa versa), so computing them from the same callback is more efficient than having two separate callbacks.

@rmcgibbo
Copy link
Owner

I rebased my branch and did a git push --force but it seems that the problem is still there. Could you have a check?

Hopefully fixed by #11.

@zhou13
Copy link
Author

zhou13 commented Dec 28, 2015

Is there a way that you can make it backwards compatible with the old API? Maybe using the same pattern that the jac argument to scipy.optimize.minimize uses, taking a callable or True.

That's a good idea. I will implement that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants