Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nether island region heights configurable #1176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

addstar
Copy link

@addstar addstar commented May 11, 2019

As discussed in #1172, the nether region height was inadvertently adjusted a while ago. And although it's now fixed in master, I thought it would be good to have this configurable.

Server owners can now set minY and maxY for the island regions created in the nether.

The default values in config (and code) are now:

worldguard:
  nether:
    minY: 6
    minX: 120

@Muspah
Copy link
Collaborator

Muspah commented May 11, 2019

Thanks for your PR! Sounds like a good idea to make this configurable, but I'm not sure if we want the user to directly control the setY() calls via the config option. It might create cases where users put in impossible values. Another thing we need to check is if/how the user can recreate the WorldGuard regions (protectall?) after changing this settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants