-
Notifications
You must be signed in to change notification settings - Fork 15
Add support for nested dialogs #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I'm sorry I didn't react to this yet, I'll try to get to it soon |
Got rid of most "any" types
Hi, |
@suzumejakku I don't have time to work on this anymore and at the moment I'm not doing any frontend work so I don't need this library myself. If people tell me this PR is fine and it doesn't break anything, I'll merge it and make this version 0.4.0. Sorry if this isn't a very responsible attitude but unless someone volunteers to maintain this project it's how it's going to be :-( |
@rlemaigre thanks for your prompt answer, really appreciate it. I can unfortunately not take the time to maintain this library. So in the end I guess I will have to use something else. I am struggling quite hard in my migration from Vue 2 with bootstrap-vue to Vue 3 and bootstrap-vue-next, as promise-based modals have been removed in bootstrap-vue-next. Your solution (with the nested dialogs of this PR) looked promising, but if it is not maintained I will refrain from using it. May I suggest to add a comment on the main page of this library indicating that it is not maintained anymore ? |
Hey there. Excellent work thus far on this PR. Looks like its not actually going to be merged and released. I have been testing it and I am seeing one issue: my custom dialog animations are no longer working. I've got everything wrapped in a
And in my `App.vue' file I've got this, just like the docs:
Watching the dialogs open and close it shows that the classes for enter and leave are not properly being applied... |
Addresses #9
Please do not afraid lots of changes, most of them are related to formatting.
I've added basic prettier settings to be sure that wouldn't happen again, if all developers will be using single settings directly from repository.
most of important changes are related to changing
to
in
lib.ts
andDialogWrapper.vue