Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use done status to mark end of message seq #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Yuhta
Copy link

@Yuhta Yuhta commented Dec 14, 2015

Seem done marks the end of a message seq: https://github.com/clojure/tools.nrepl/blob/master/src/main/clojure/clojure/tools/nrepl.clj#L86.

Currently if the response contains eval-error there will be some messages (the exception message and the done) not appended to the buffer. Please advice if there is special reason why that code was commented out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant