Refactor to have a public message format function #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One function to format the git message and will be a public function in git mob core.
Integrate into append message function is the main usage.
The message formatter now supports the signed off by trailer. #121
Need more thought on the approach to support multiple author trailers.
Update change log and readme about one message format function.
rkotze
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor description
Public API for git mob core will have a message formatter function to handle co-author trailers only. This should be used in consuming apps to format git message co-author trailers like Git Mob VS Code.
This has been built for extension in mind at a later point to support multiple trailers.
Pull request checklist
CHANGELOG.mdto capture my changesnpm run build) was successfully run locallynpm run checks) has passed locallyPull request type
Please check the type of change your PR introduces:
Does this introduce a breaking change?