fix for comment 3 in PR 59 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkarlsba
approved these changes
Jul 5, 2017
|
merged into my fork for now together with some variable reality check (var=0, not var="0"etc). Seems to work well for me. Can look into merging this to upstream later if nothing much has happened. Please take a look.
Also - thanks a lot
Vennlig hilsen / Best regards
roy
--
Roy Sigurd Karlsbakk
(+47) 98013356
http://blogg.karlsbakk.net/
GPG Public key: http://karlsbakk.net/roysigurdkarlsbakk.pubkey.txt
--
Da mihi sis bubulae frustrum assae, solana tuberosa in modo Gallico fricta, ac quassum lactatum coagulatum crassum. Quod me nutrit me destruit.
… From: "Marc A. Bonsels" ***@***.***>
To: "rkarlsba/zfs-auto-snapshot" ***@***.***>
Cc: "Subscribed" ***@***.***>
Sent: Wednesday, 5 July, 2017 17:40:39
Subject: [rkarlsba/zfs-auto-snapshot] fix for comment 3 in PR 59 (#1)
You can view, comment on, or merge this pull request online at:
[ #1 |
#1 ]
Commit Summary
* workaround issue in comment #3 of PR 59
* Update zfs-auto-snapshot.sh
File Changes
* M [ https://github.com/rkarlsba/zfs-auto-snapshot/pull/1/files#diff-0 |
src/zfs-auto-snapshot.sh ] (60)
Patch Links:
* [ https://github.com/rkarlsba/zfs-auto-snapshot/pull/1.patch |
https://github.com/rkarlsba/zfs-auto-snapshot/pull/1.patch ]
* [ https://github.com/rkarlsba/zfs-auto-snapshot/pull/1.diff |
https://github.com/rkarlsba/zfs-auto-snapshot/pull/1.diff ]
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, [
#1 | view it on GitHub ] , or
[
https://github.com/notifications/unsubscribe-auth/AEDl2w_2oRK7UpfKPW-Aspg7EyV9H-gWks5sK652gaJpZM4OOg7l
| mute the thread ] .
|
|
happy for that, thank you! |
|
otherwise it looks okay |
|
Hi Roy, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.