Bug: schema with conditions where switching to then/else subschemas did not reflect the actual validation errors in the onChange event. #4432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes #4249
Additional improvement
The
ajv.compile
method is costly in terms of performance when it has to recompile ononChange
or onprops
change. To improve this we now provide the sameretrievedSchema
(by reference) unless it changes in which case we provide a newretrievedSchema
. This ensures that AJV retrieves the schema from the cache unless the retrievedSchema content changes then it will recompile.I've run the test with a very large schema(link attached) the compile used to take 640ms and now it takes 40ms. You can see the performance improvement if you load the link in the attached file in the main branch and compare it to this feature branch. You'll notice by typing in any field that it is massively slow on the main branch.
rjsf-playground-link (2).txt
Checklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update
to update snapshots, if needed.