Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return correct value for base64 and empty strings #21

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Return correct value for base64 and empty strings #21

wants to merge 8 commits into from

Conversation

aarong
Copy link

@aarong aarong commented Nov 17, 2011

  1. AWS returns base64 strings for attribute values that contain XML-restricted characters (such as \u0000) -- detect and decode these values.
  2. The XML parser used by aws-lib returns empty strings as {} -- check for these and return "" to the client.

@rjrodger
Copy link
Owner

rjrodger commented Apr 6, 2012

Hi Aaron - just trying to understand this pull request - do you have a test case for the problem it is solving?
thanks!

@rjrodger
Copy link
Owner

Sorry for the lack of action on my part - I made you a collaborator, so feel free to merge directly :)

@tracend
Copy link
Collaborator

tracend commented May 1, 2014

@aarong would like to know if this is addressed in later versions of aws-lib.

Should we close this request or update it?

@rjrodger
Copy link
Owner

I too out of the loop to comment, but note that I have made this project Open-Open: https://github.com/rvagg/node-levelup/blob/master/CONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants