-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Regex from analyzers #81
Merged
MattKotsenas
merged 7 commits into
rjmurillo:main
from
MattKotsenas:refactor/remove-regex
Jun 12, 2024
Merged
Remove Regex from analyzers #81
MattKotsenas
merged 7 commits into
rjmurillo:main
from
MattKotsenas:refactor/remove-regex
Jun 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattKotsenas
force-pushed
the
refactor/remove-regex
branch
from
June 12, 2024 07:06
53e1081
to
a4bb21e
Compare
rjmurillo
reviewed
Jun 12, 2024
rjmurillo
approved these changes
Jun 12, 2024
github-actions
bot
added
dependencies
Pull requests that update a dependency file
build
labels
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace using a
Regex
on string-ified type names with the proper Roslyn API (usually Identifier.Name) and do some 'straightening' of the code using early-returns and pattern matching to reduce the triangle-ness.This is effectively a rewrite of
AsShouldBeUsedOnlyForInterfaceAnalyzer
. There's a smaller refactor forCallbackSignatureShouldMatchMockedMethod*
as that code needs to be shared between the analyzer and the code fix provider (will be handled later)This refactor has a few benefits:
CancellationToken
into more places to be a good IDE citizenThis PR also starts to break apart the monolithic
Helpers
class into smaller components. In order to support the.TryXXX
pattern I needed to bring in a polyfill for[NotNullWhen]
for nullability analysis. I'm using PolySharp because, in addition to being the most popular polyfill, it uses a source generator to add polyfills to the current assembly, which avoid assembly loading overhead and the hassle of adding dependencies to the analyzer.