Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dotnet test when not generating code coverage reports #80

Merged

Conversation

MattKotsenas
Copy link
Collaborator

@MattKotsenas MattKotsenas commented Jun 11, 2024

#79 added code coverage reports, but broke a basic dotnet test. In that case no Cobertura reports are generated and thus the <ReportGenerator> task fails.

Fix by conditioning the report generator on having reports to process.

@MattKotsenas MattKotsenas requested a review from rjmurillo June 11, 2024 18:42
@MattKotsenas MattKotsenas enabled auto-merge (squash) June 11, 2024 18:42
@MattKotsenas MattKotsenas merged commit 0a7f49a into rjmurillo:main Jun 11, 2024
3 checks passed
@rjmurillo rjmurillo added this to the vNext milestone Jun 11, 2024
@MattKotsenas MattKotsenas deleted the bugfix/test-report-missing branch June 11, 2024 18:47
@rjmurillo rjmurillo added the bug label Jun 12, 2024
@github-actions github-actions bot added the build label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants