Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ConcurrentExecution and disable generated code analysis #70

Merged

Conversation

MattKotsenas
Copy link
Collaborator

Two simple and related performance improvements:

  1. Enable concurrent execution of the analyzer. Verified via manual code inspection + tests that there's no state to maintain between invocations
  2. Disable the analyzer in generate code contexts. Things like Razor and Entity Framework can generate large volumes of code that the user isn't directly responsible for.

@MattKotsenas
Copy link
Collaborator Author

I don't want to DRY this out via a base class, as it merely happens to be that the generated code configuration is the same for all the analyzers and the behavior is already caught with a test.

Concurrent execution is caught via RS1026, which I'd like to enforce via WarningsAsErrors.

@MattKotsenas MattKotsenas enabled auto-merge (squash) June 7, 2024 17:19
@MattKotsenas MattKotsenas requested a review from rjmurillo June 7, 2024 17:19
@MattKotsenas MattKotsenas merged commit 9429e11 into rjmurillo:main Jun 7, 2024
4 checks passed
@rjmurillo rjmurillo added this to the vNext milestone Jun 7, 2024
@MattKotsenas MattKotsenas deleted the feature/configure-analyzers branch June 7, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants