-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor tests to simplify and inline test cases #57
Merged
rjmurillo
merged 32 commits into
rjmurillo:master
from
MattKotsenas:refactor/split-tests
Jun 5, 2024
Merged
Refactor tests to simplify and inline test cases #57
rjmurillo
merged 32 commits into
rjmurillo:master
from
MattKotsenas:refactor/split-tests
Jun 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattKotsenas
changed the title
Refactor tests to simplify and inline test case
Refactor tests to simplify and inline test cases
Jun 5, 2024
rjmurillo
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MattKotsenas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mechanical refactor as a prerequisite for improving test coverage and moving from a custom test harness over to the Microsoft.CodeAnalysis.Testing harness.
Each test class used the same procedure:
Data\*.cs
file into multiple files, one per test method[Fact]
s, one perData
class and accept baselinesData
class and accept baselinesData
class into the test harnessThe CodeFix test is a bit different. Because the diagnostics and code fix should be tested together, I inlined those
Data
classes into a string. A future refactor to use the Microsoft.CodeAnalysis.Testing harness will further clean those up.Added a few TODOs where test coverage appears unnecessary or missing, but avoided adding it in this change due to the difficulty of review.