Add cancellation tokens to methods that have a parameter but we don't pass #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most often this was while getting the type information from the semantic model. In cases where the asynchronous operation is cancelled, the underlying calls would not be aborted because we did not propagate forward the cancellation token. This was not picked up by analyzer CA2016 because the cancellation token is not provided on the method used by
DiagnosticAnalyzer
, but rather on theSyntaxNodeAnalysisContext
instance passed in.The issue was corrected by adding a new analyzer package and enabling an analyzer rule within that package. Both rules are set to error in
.editorconfig
to avoid introducing new code with this issueFixes #43