Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move usings to top of file and using file-scoped namespaces #40

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

MattKotsenas
Copy link
Collaborator

This is a mechanical change to:

  1. Move usings to the top of the file
  2. Use file-scoped namespace declarations

These two refactorings are done together because they touch every file and would otherwise be a source of merge conflicts.

In order to enforce these changes going forward, I made the following changes to .editorconfig:

  • dotnet_separate_import_directive_groups = false to not require the blank space between "1st party" and "3rd party" usings
  • Upgrade csharp_using_directive_placement = outside_namespace:warning to a warning
  • Add csharp_style_namespace_declarations = file_scoped:warning as a warning

@MattKotsenas
Copy link
Collaborator Author

Reviewer's note: Consider hitting "ignore whitespace" and use the split view.

@rjmurillo rjmurillo self-assigned this Jun 3, 2024
@rjmurillo rjmurillo modified the milestone: 0.1.X Jun 3, 2024
@rjmurillo rjmurillo merged commit 3e12add into rjmurillo:master Jun 3, 2024
3 checks passed
@MattKotsenas MattKotsenas deleted the refactor/usings branch June 3, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants