Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move minimum support to sdk 8 #295

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Move minimum support to sdk 8 #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b32d882
Update global.json to rollForward to `patch`
rjmurillo Dec 20, 2024
11fb8f7
Update comments about SDK versions
rjmurillo Dec 20, 2024
fcda2c6
Remove use of obsolete overload Compilation.WithAnalyzers using a Can…
rjmurillo Dec 20, 2024
b3f6d03
Move benchmarks to TFM net8.0 -> net9.0
rjmurillo Dec 20, 2024
42c57ac
Update SquiggleCop baseline
rjmurillo Dec 20, 2024
026824c
Update SquiggleCop baselines
rjmurillo Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,14 @@
These items impact our compatibility with SDK versions, so follow
to strike a balance between compatibility and modernity.

These are the two main documents to reference how the Public API impacts users:
- https://github.com/dotnet/roslyn/blob/main/docs/wiki/NuGet-packages.md
These are the three main documents to reference how the Public API impacts users:
- https://github.com/dotnet/roslyn/blob/main/docs/wiki/NuGet-packages.md?plain=1
- https://learn.microsoft.com/en-us/dotnet/core/porting/versioning-sdk-msbuild-vs#lifecycle
- https://learn.microsoft.com/en-us/visualstudio/productinfo/vs-servicing
-->
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.3.1" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.3.1" />
<!-- We are using 4.8, which introduces .NET 8 and supports VS 2022 17.8 -->
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.8" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.8" />
</ItemGroup>
<ItemGroup>
<PackageVersion Include="Microsoft.CodeAnalysis.AnalyzerUtilities" Version="3.11.0-beta1.24527.2" />
Expand Down
2 changes: 1 addition & 1 deletion global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"sdk": {
"version": "9.0.100",
"rollForward": "disable"
"rollForward": "patch"
},
"msbuild-sdks": {
"DotNet.ReproducibleBuilds.Isolated": "1.2.25"
Expand Down
1,429 changes: 715 additions & 714 deletions src/Analyzers/SquiggleCop.Baseline.yaml
View file
Open in desktop

Large diffs are not rendered by default.

1,429 changes: 715 additions & 714 deletions src/CodeFixes/SquiggleCop.Baseline.yaml
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions tests/Moq.Analyzers.Benchmarks/Helpers/BenchmarkCSharpCompilationFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ internal static class BenchmarkCSharpCompilationFactory
throw new InvalidOperationException("Failed to create compilation");
}

CompilationWithAnalyzers baseline = compilation.WithAnalyzers([new EmptyDiagnosticAnalyzer()], options, CancellationToken.None);
CompilationWithAnalyzers test = compilation.WithAnalyzers([new TAnalyzer()], options, CancellationToken.None);
CompilationWithAnalyzers baseline = compilation.WithAnalyzers([new EmptyDiagnosticAnalyzer()], options);
CompilationWithAnalyzers test = compilation.WithAnalyzers([new TAnalyzer()], options);

return (baseline, test);
}
Expand All @@ -37,9 +37,9 @@ internal static class BenchmarkCSharpCompilationFactory
throw new InvalidOperationException("Failed to create compilation");
}

CompilationWithAnalyzers baseline = compilation.WithAnalyzers([new EmptyDiagnosticAnalyzer()], options, CancellationToken.None);
CompilationWithAnalyzers test1 = compilation.WithAnalyzers([new TAnalyzer1()], options, CancellationToken.None);
CompilationWithAnalyzers test2 = compilation.WithAnalyzers([new TAnalyzer2()], options, CancellationToken.None);
CompilationWithAnalyzers baseline = compilation.WithAnalyzers([new EmptyDiagnosticAnalyzer()], options);
CompilationWithAnalyzers test1 = compilation.WithAnalyzers([new TAnalyzer1()], options);
CompilationWithAnalyzers test2 = compilation.WithAnalyzers([new TAnalyzer2()], options);

return (baseline, test1, test2);
}
Expand Down
2 changes: 1 addition & 1 deletion tests/Moq.Analyzers.Benchmarks/Moq.Analyzers.Benchmarks.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net9.0</TargetFramework>
<IsPackable>false</IsPackable>
</PropertyGroup>

Expand Down
1,436 changes: 718 additions & 718 deletions tests/Moq.Analyzers.Benchmarks/SquiggleCop.Baseline.yaml
View file
Open in desktop

Large diffs are not rendered by default.

1,429 changes: 715 additions & 714 deletions tests/Moq.Analyzers.Test.Analyzers/SquiggleCop.Baseline.yaml
View file
Open in desktop

Large diffs are not rendered by default.

1,510 changes: 755 additions & 755 deletions tests/Moq.Analyzers.Test/SquiggleCop.Baseline.yaml
View file
Open in desktop

Large diffs are not rendered by default.

Loading