Migrate from ApprovalTests to Verify #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we want to be sticklers about the warnings I can back out the compiler flags change and do it separately. However I assume we'll want those soon anyways. Let me know. |
|
@rjmurillo this is ready for review / merge |
rjmurillo
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate from ApprovalTests to Verify. The change was entirely mechanical with no manual changes required:
[UseReporter]voidin test signature withTaskApprovals.Verifywithreturn Verify*.approved.txtwith*.verified.txt*.approved.txt.bakfiles, which appear to be leftovers from a Visual Studio migration in commit d64e270Verify makes use of implicit usings, so I enabled:
via a
.propsfile. This introduces new warnings about nullability. I'm leaving those for cleanup in another PR.Fixes #12.