Moq1100 incorrectly firing on nullable parameters

[rjmurillo]

Update type comparison to use ClassifyConversion to check if the types are assignable, rather than stringly strictly equal.

Changes:

• Add check for types based on assignability (which also covers user-defined implicit and explicit conversions), rather than strictly equal with types.
• Add logging for test type to aid in debugging cases
• Update detection (span for diagnostic is tighter now)
• Add repro for issue reported in Moq1100 incorrectly firing on nullable parameters #172 (thanks @marcovr!)
• Add test cases for user-defined implicit and explicit conversions (thanks @MattKotsenas!)

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.07% (target: -1.00%)	✅ 100.00% (target: 95.00%)

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (a80f55a)	551	509	92.38%
Head commit (7b16be7)	556 (+5)	514 (+5)	92.45% (+0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#187)	16	16	100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

[codeclimate]

Code Climate has analyzed commit 7b16be7 and detected 0 issues on this pull request.

View more on Code Climate.