Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SonarAnalyzer.CSharp from 9.31.0.96804 to 9.32.0.97167 #183

Merged
merged 6 commits into from
Aug 26, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 15, 2024

Bumps SonarAnalyzer.CSharp from 9.31.0.96804 to 9.32.0.97167.

Release notes

Sourced from SonarAnalyzer.CSharp's releases.

9.32

This rule includes the promotion of 4 rules to Sonar-way, the deprecation of 1 rule and 2 FP fixes.

Rule Promotions and Deprecations

  • 9644 - Modify S2387: Deprecate rule
  • 9643 - Modify S4050: Promote to Sonar-way
  • 9642 - Modify S2674: Promote to Sonar-way
  • 9641 - Modify S3993: Promote to Sonar-way
  • 9640 - Modify S4052: Promote to Sonar-way

False Positive

  • 9590 - [C#] Fix S6966 FP: EntityFrameworks IDbContextFactory CreateDbContext method is preferred over its Async counterpart
  • 8300 - [C#] Fix S3431 FP: Don't raise if assertions are done in catch or finally
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @rjmurillo.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added .NET Pull requests that update .net code dependencies Pull requests that update a dependency file labels Aug 15, 2024
@CLAassistant
Copy link

CLAassistant commented Aug 15, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ MattKotsenas
✅ rjmurillo
❌ dependabot[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@rjmurillo
Copy link
Owner

@dependabot squash and merge

@dependabot dependabot bot force-pushed the dependabot/nuget/SonarAnalyzer.CSharp-9.32.0.97167 branch from a78bda2 to 4dcbae9 Compare August 18, 2024 21:11
rjmurillo
rjmurillo previously approved these changes Aug 18, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 18, 2024

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

Bumps [SonarAnalyzer.CSharp](https://github.com/SonarSource/sonar-dotnet) from 9.31.0.96804 to 9.32.0.97167.
- [Release notes](https://github.com/SonarSource/sonar-dotnet/releases)
- [Commits](SonarSource/sonar-dotnet@9.31.0.96804...9.32.0.97167)

---
updated-dependencies:
- dependency-name: SonarAnalyzer.CSharp
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/nuget/SonarAnalyzer.CSharp-9.32.0.97167 branch from 4dcbae9 to 3166bfe Compare August 26, 2024 16:11
rjmurillo
rjmurillo previously approved these changes Aug 26, 2024
@rjmurillo rjmurillo added this to the v0.2.0 milestone Aug 26, 2024
@rjmurillo rjmurillo added the analyzers Change that impacts an analyzer behavior label Aug 26, 2024
@MattKotsenas MattKotsenas requested a review from rjmurillo August 26, 2024 16:25
Copy link

codacy-production bot commented Aug 26, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) (target: 95.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5703f4e) 527 488 92.60%
Head commit (ce76031) 527 (+0) 488 (+0) 92.60% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#183) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codeclimate bot commented Aug 26, 2024

Code Climate has analyzed commit ce76031 and detected 0 issues on this pull request.

View more on Code Climate.

@rjmurillo rjmurillo merged commit 0bccdf6 into main Aug 26, 2024
9 of 10 checks passed
@rjmurillo rjmurillo deleted the dependabot/nuget/SonarAnalyzer.CSharp-9.32.0.97167 branch August 26, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzers Change that impacts an analyzer behavior build dependencies Pull requests that update a dependency file .NET Pull requests that update .net code releasable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants