Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BDN perf comparison tool from roslyn analyzers #119

Merged
merged 15 commits into from
Jun 25, 2024
Merged

Conversation

rjmurillo
Copy link
Owner

@rjmurillo rjmurillo commented Jun 25, 2024

Add BenchmarkDotNet (BDN) to part of build. Compare against a baseline as a git commit hash. If there is a performance difference above threshold, fail the build step.

Changes

  • Add infrastructure from Roslyn Analyzers infrastructure (PowerShell and tools)
  • Performance tests use ETL, so only run on Windows. Add .cmd files to call into PowerShell files in build/scripts/perf and to run locally in repo root.

The tools and scripts were largely copied with minimal modifications. This is to reduce variance from "upstream". Improvements to this tool are tracked in #130

Fixes #129

@rjmurillo rjmurillo added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code releasable build feature labels Jun 25, 2024
@rjmurillo rjmurillo requested a review from MattKotsenas June 25, 2024 01:02
@rjmurillo rjmurillo added this to the 0.1.1 milestone Jun 25, 2024
Copy link

codacy-production bot commented Jun 25, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) (target: 95.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2dcad69) 458 423 92.36%
Head commit (8b34a42) 458 (+0) 423 (+0) 92.36% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#119) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@rjmurillo rjmurillo removed the request for review from MattKotsenas June 25, 2024 04:16
@rjmurillo rjmurillo self-assigned this Jun 25, 2024
@rjmurillo rjmurillo requested a review from MattKotsenas June 25, 2024 18:55
@rjmurillo rjmurillo marked this pull request as ready for review June 25, 2024 19:26
@rjmurillo rjmurillo enabled auto-merge (squash) June 25, 2024 19:28
@rjmurillo rjmurillo merged commit 729c531 into main Jun 25, 2024
7 checks passed
@rjmurillo rjmurillo deleted the feature/perf-tools branch June 25, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build dependencies Pull requests that update a dependency file feature github_actions Pull requests that update GitHub Actions code releasable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With the addition of BenchmarkDotNet, use tests to gate PRs from performance regression
2 participants