Inline SetupShouldNotIncludeAsyncResult tests

rjmurillo · Jun 5, 2024 · db0b3cb · db0b3cb
1 parent 0c118b6
commit db0b3cb
Show file tree

Hide file tree

Showing 5 changed files with 77 additions and 70 deletions.
diff --git a/Source/Moq.Analyzers.Test/Data/SetupShouldNotIncludeAsyncResult.TestBadForGenericTask.cs b/Source/Moq.Analyzers.Test/Data/SetupShouldNotIncludeAsyncResult.TestBadForGenericTask.cs
diff --git a/...q.Analyzers.Test/Data/SetupShouldNotIncludeAsyncResult.TestOkForGenericTaskProperSetup.cs b/...q.Analyzers.Test/Data/SetupShouldNotIncludeAsyncResult.TestOkForGenericTaskProperSetup.cs
diff --git a/Source/Moq.Analyzers.Test/Data/SetupShouldNotIncludeAsyncResult.TestOkForTask.cs b/Source/Moq.Analyzers.Test/Data/SetupShouldNotIncludeAsyncResult.TestOkForTask.cs
diff --git a/Source/Moq.Analyzers.Test/Moq.Analyzers.Test.csproj b/Source/Moq.Analyzers.Test/Moq.Analyzers.Test.csproj
@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <TargetFramework>net8.0</TargetFramework>
@@ -41,10 +41,5 @@
   <ItemGroup>
     <ProjectReference Include="..\Moq.Analyzers\Moq.Analyzers.csproj" AddPackageAsOutput="true" />
   </ItemGroup>
-  <ItemGroup>
-    <Compile Update="Data\**\*.cs">
-      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
-    </Compile>
-  </ItemGroup>
 
 </Project>
diff --git a/Source/Moq.Analyzers.Test/SetupShouldNotIncludeAsyncResultAnalyzerTests.cs b/Source/Moq.Analyzers.Test/SetupShouldNotIncludeAsyncResultAnalyzerTests.cs
@@ -11,19 +11,92 @@ public class SetupShouldNotIncludeAsyncResultAnalyzerTests : DiagnosticVerifier
     [Fact]
     public Task ShouldPassWhenSetupWithoutReturn()
     {
-        return Verify(VerifyCSharpDiagnostic(File.ReadAllText("Data/SetupShouldNotIncludeAsyncResult.TestOkForTask.cs")));
+        return Verify(VerifyCSharpDiagnostic(
+            [
+                """
+                using System.Threading.Tasks;
+                using Moq;
+
+                namespace SetupShouldNotIncludeAsyncResult.TestOkForTask;
+
+                public class AsyncClient
+                {
+                    public virtual Task TaskAsync() => Task.CompletedTask;
+
+                    public virtual Task<string> GenericTaskAsync() => Task.FromResult(string.Empty);
+                }
+
+                internal class MyUnitTests
+                {
+                    private void TestOkForTask()
+                    {
+                        var mock = new Mock<AsyncClient>();
+                        mock.Setup(c => c.TaskAsync());
+                    }
+                }
+                """
+            ]));
     }
 
     [Fact]
     public Task ShouldPassWhenSetupWithReturnsAsync()
     {
-        return Verify(VerifyCSharpDiagnostic(File.ReadAllText("Data/SetupShouldNotIncludeAsyncResult.TestOkForGenericTaskProperSetup.cs")));
+        return Verify(VerifyCSharpDiagnostic(
+            [
+                """
+                using System.Threading.Tasks;
+                using Moq;
+
+                namespace SetupShouldNotIncludeAsyncResult.TestOkForGenericTaskProperSetup;
+
+                public class AsyncClient
+                {
+                    public virtual Task TaskAsync() => Task.CompletedTask;
+
+                    public virtual Task<string> GenericTaskAsync() => Task.FromResult(string.Empty);
+                }
+
+                internal class MyUnitTests
+                {
+                    private void TestOkForGenericTaskProperSetup()
+                    {
+                        var mock = new Mock<AsyncClient>();
+                        mock.Setup(c => c.GenericTaskAsync())
+                            .ReturnsAsync(string.Empty);
+                    }
+                }
+                """
+            ]));
     }
 
     [Fact]
     public Task ShouldFailWhenSetupWithTaskResult()
     {
-        return Verify(VerifyCSharpDiagnostic(File.ReadAllText("Data/SetupShouldNotIncludeAsyncResult.TestBadForGenericTask.cs")));
+        return Verify(VerifyCSharpDiagnostic(
+            [
+                """
+                using System.Threading.Tasks;
+                using Moq;
+
+                namespace SetupShouldNotIncludeAsyncResult.TestBadForGenericTask;
+
+                public class AsyncClient
+                {
+                    public virtual Task TaskAsync() => Task.CompletedTask;
+
+                    public virtual Task<string> GenericTaskAsync() => Task.FromResult(string.Empty);
+                }
+
+                internal class MyUnitTests
+                {
+                    private void TestBadForGenericTask()
+                    {
+                        var mock = new Mock<AsyncClient>();
+                        mock.Setup(c => c.GenericTaskAsync().Result);
+                    }
+                }
+                """
+            ]));
     }
 
     protected override DiagnosticAnalyzer GetCSharpDiagnosticAnalyzer()