Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This PR fixes 3 problems we encountered in the recursive tree watcher implementation and adds 2 new tests:
I added a new test called
TestStopChild
that tests explicitly for this problem.TestAddParentAfterStop
that tests explicitly for this problem. With the fixes introduced in this PR, the code snippet in FSEvents: fix bug where rewatching path fails across channels #155 runs fine without any panicsStop()
,RecursiveUnwatch
is never called, becausewatchIsRecursive(nd)
is called after the watchpoint was already removed and hence the check always returns that the watch is not recursive