Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract histograms and bars into RzCons #3189

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Extract histograms and bars into RzCons #3189

merged 1 commit into from
Nov 17, 2022

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Nov 16, 2022

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

  • Extract histograms code into librz/cons/histogram.c
  • Extract bars (progressbar and rangebar) into librz/cons/bar.c
  • Initially I wanted to put them into librz/util/ but they use RzConsPalette for colors, so I put them into RzCons

Test plan

  • CI is green
  • Play with various p= and p- commands

Closing issues

A prerequisite for converting p- and p= to rzhell: #1590

wargio
wargio approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, besides a couple of comments

@wargio wargio merged commit f2ca09f into dev Nov 17, 2022
@wargio wargio deleted the asan-histogram branch November 17, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio wargio approved these changes

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

Assignees
No one assigned
Labels
API rz-test RzCons RzCore RzUtil
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XVilka @wargio