Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the RzCore meta API #2131

Merged
merged 6 commits into from
Dec 23, 2021
Merged

Expose the RzCore meta API #2131

merged 6 commits into from
Dec 23, 2021

Conversation

imbillow
Copy link
Contributor

@imbillow imbillow commented Dec 22, 2021

SQUASH ME

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

...

Test plan

...

Closing issues

...

@imbillow
Copy link
Contributor Author

rizinorg/cutter#2861

@XVilka
Copy link
Member

XVilka commented Dec 22, 2021

I think analysis should not depend on IO. Better to move those APIs to librz/core/cmeta.c

librz/analysis/meta.c Outdated Show resolved Hide resolved
librz/analysis/meson.build Outdated Show resolved Hide resolved
librz/core/cmeta.c Show resolved Hide resolved
librz/core/cmeta.c Show resolved Hide resolved
@imbillow
Copy link
Contributor Author

doxygen runs much slower than compiled code

@XVilka
Copy link
Member

XVilka commented Dec 22, 2021

Ubuntu clang-format version 13.0.1-++20211221063253+abc0cf92bb14-1~exp1~20211221183333.39
librz/core/cmeta.c:427:3: error: code should be clang-formatted [-Wclang-format-violations]
 * 
  ^
librz/core/cmeta.c:431:37: error: code should be clang-formatted [-Wclang-format-violations]
 * \param encoding string's encoding 
                                    ^

@imbillow
Copy link
Contributor Author

imbillow commented Dec 22, 2021

  • a asyncCmdEsil * 9, asyncCmd * 1 cmdRawAt * 2 cmdj * 3, cmdjAt * 2
  • p cmdRawAt * 2
  • f cmdRaw * 8, cmdj * 1
  • e cmdRaw * 1, cmdj * 6
  • w cmdRaw * 2, cmdj * 1
  • o cmdRaw * 4, cmdj * 1
  • d asyncCmd * 10, cmdRaw * 2, cmdj * 8
  • i cmdj * 11, cmdjTask * 1
  • v cmdj * 1
  • C
  • z cmdj * 1
  • . cmdTask * 1

#1342
Some of the more used commands have not been porting to the tree-sitter-based one

@imbillow

This comment has been minimized.

@XVilka
Copy link
Member

XVilka commented Dec 22, 2021

@imbillow yeah, it's a recent change, this script should be changed:
https://github.com/rizinorg/rizin/blob/dev/sys/clang-format.py#L14
cc @ret2libc

Copy link
Member

@ret2libc ret2libc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from that small thing

librz/core/cmeta.c Show resolved Hide resolved
librz/core/cmeta.c Outdated Show resolved Hide resolved
@XVilka XVilka changed the title Make some librz API for cutter use Expose the RzCore meta API Dec 23, 2021
@XVilka XVilka merged commit c4f9df4 into dev Dec 23, 2021
@XVilka XVilka deleted the make-api branch December 23, 2021 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants