Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove oldshell version of s commands #1895

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Remove oldshell version of s commands #1895

merged 1 commit into from
Oct 27, 2021

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Oct 27, 2021

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the documentation and the rizin book with the relevant information (if needed)

Detailed description

Remove now unnecessary code for s (seek) commands

Test plan

CI is green.

Relevant to #1342

@XVilka XVilka requested a review from ret2libc October 27, 2021 10:08
@XVilka XVilka merged commit a7ebf7b into dev Oct 27, 2021
@XVilka XVilka deleted the asan-seek-cleanup branch October 27, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ret2libc ret2libc ret2libc approved these changes

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@wargio wargio Awaiting requested review from wargio wargio is a code owner

Assignees
No one assigned
Labels
RzCore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XVilka @ret2libc