fix!: Torbox Removal #971
fix!: Torbox Removal #971
Conversation
WalkthroughThis pull request comprehensively removes the TorBox downloader and scraper functionality from the application. The changes span multiple files across the project, including configuration files, service modules, type definitions, and router endpoints. The removal involves deleting entire classes, type hints, configuration models, and API endpoints related to TorBox, effectively eliminating all TorBox-specific code and configuration options from the system. Changes
Possibly related PRs
Suggested Reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/program/services/downloaders/__init__.py (2)
22-22: Consider removing the commented import instead of just commenting it out.Since we're completely removing the Torbox feature, we should remove this commented import line rather than keeping it as a comment.
-# from .torbox import TorBoxDownloader
29-33: Consider updating the service initialization logic.The service initialization could be simplified now that we have fewer services. Consider refactoring the services dictionary initialization to be more explicit:
- self.services = { - RealDebridDownloader: RealDebridDownloader(), - # TorBoxDownloader: TorBoxDownloader(), - AllDebridDownloader: AllDebridDownloader() - } + self.services = { + RealDebridDownloader: RealDebridDownloader(), + AllDebridDownloader: AllDebridDownloader() + }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
poetry.lockis excluded by!**/*.lock
📒 Files selected for processing (9)
.env.example(0 hunks)src/program/services/downloaders/__init__.py(2 hunks)src/program/services/downloaders/torbox.py(0 hunks)src/program/services/scrapers/__init__.py(0 hunks)src/program/services/scrapers/torbox.py(0 hunks)src/program/settings/models.py(0 hunks)src/program/types.py(2 hunks)src/routers/secure/default.py(0 hunks)src/tests/test_settings_migration.py(0 hunks)
💤 Files with no reviewable changes (7)
- src/program/services/scrapers/init.py
- src/tests/test_settings_migration.py
- src/routers/secure/default.py
- .env.example
- src/program/services/scrapers/torbox.py
- src/program/services/downloaders/torbox.py
- src/program/settings/models.py
🔇 Additional comments (3)
src/program/types.py (2)
33-33: LGTM! TorBoxScraper correctly removed from Union type.The removal of TorBoxScraper from the Scraper Union type is consistent with the PR objective of removing the Torbox feature.
36-38: LGTM! TorBoxDownloader correctly removed from Union type.The removal of TorBoxDownloader from the Downloader Union type is consistent with the PR objective. The commented AllDebridDownloader entry is preserved as it's unrelated to this change.
src/program/services/downloaders/__init__.py (1)
31-32: Verify the impact of removing TorBoxDownloader from services.The removal of TorBoxDownloader from services looks correct, but let's verify that this doesn't affect service initialization for existing users.
✅ Verification successful
TorBoxDownloader removal is clean and safe
The service has been completely removed with no remaining dependencies or configuration requirements. The only references are commented-out lines in the services initialization, which don't affect runtime behavior.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for any remaining TorBox configuration or usage in the codebase # Check for any remaining TorBox configuration echo "Checking for TorBox configuration..." rg -i "torbox" .env* || echo "No TorBox configuration found" # Check for any remaining TorBox imports or usage echo "Checking for TorBox usage..." rg -i "torbox" src/ || echo "No TorBox usage found" # Check settings migration tests for TorBox references echo "Checking settings migration..." rg -i "torbox" src/tests/test_settings_migration.py || echo "No TorBox settings migration found"Length of output: 649
Script:
#!/bin/bash # Check for any remaining class references or imports echo "Checking for TorBoxDownloader class references..." rg -i "torboxdownloader" src/ # Check for any torbox module imports echo "Checking for torbox module imports..." rg -i "from.*torbox.*import" src/ # Check if torbox.py still exists echo "Checking for torbox.py file..." fd torbox.pyLength of output: 610
Pull Request Check List
Resolves: #issue-number-here
Description:
Also updated python dependencies as well.
Summary by CodeRabbit
Removed Features
Configuration Changes