Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable takt barlines and import from Volpiano #3743

Merged
merged 7 commits into from
Sep 3, 2024

Conversation

rettinghaus
Copy link
Contributor

This PR adds reading/writing of visual attributes for barLine, enabling to draw single barlines as takt.
Also it adds basic import for barlines to Volpiano support (including breaks, which are shown as takt barlines).

Example

1---dcd---3---fef---7---dcd---4---fef---77---

image

@rettinghaus rettinghaus requested a review from lpugin August 8, 2024 15:21
@lpugin lpugin requested a review from ahankinson August 26, 2024 08:18
Copy link
Contributor

@ahankinson ahankinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is missing functions for 5 and 6 too, right?

image

@craigsapp
Copy link
Contributor

craigsapp commented Sep 2, 2024

Can number 7 (takt) be used in CMN or is this specific to neume notation? Or in any case verovio allows using it with MEI-all? I came across it last week in a modernized version (from 1877 publication) that is transcribed from earlier notation:

Screenshot 2024-09-02 at 4 43 45 AM

Either it comes from the original notation, or it was added to mark phrase boundaries/verse line. It does not occur at the colon (:) which is a regular barline

@ahankinson
Copy link
Contributor

It's all a bit weird, because technically these are more like breath marks / articulations than "bar lines".

@craigsapp
Copy link
Contributor

Perhaps, but they are not in all examples, so probably original from the original melodies. It could be that the original notation did not have barlines, but had takt only for the phrase boundaries (breath marks).

Here is a case where the takt is use to split 6/2 measures in half, so it can't mean breath marks in this song:

Screenshot 2024-09-02 at 5 19 25 AM

paper page 541 in:
https://rosdok.uni-rostock.de/mcrviewer/recordIdentifier/rosdok_ppn738218359/iview2/phys_0643.iview2?logicalDiv=log_0016

Some German can read the Fraktur font to see if its purpose is described in the introduction:-)

@ahankinson
Copy link
Contributor

I guess we should also figure out if <barLine> is appropriate, or <divLine>?

https://music-encoding.org/guidelines/dev/elements/divLine.html

https://de.wikipedia.org/wiki/Pausa_(Neume)

@rettinghaus
Copy link
Contributor Author

@ahankinson I've added ending baronies, but short bar lines are not available yet. And from what I get from Volpiano these are all bar lines.

src/iovolpiano.cpp Outdated Show resolved Hide resolved
@ahankinson
Copy link
Contributor

Well, kinda. Volpiano is designed as pseudo-chant, but with everything in modern chant it gets filtered through CMN.

Here's what the Liber Usualis has to say about these symbols:

image

So it may be that the creators of Volpiano thought of them to be like bar lines, but they were probably representing concepts that were closer to the diviso of the LU.

With Craig's example the takt seem to be more phrase markings than bar lines. Who knows, but we can't create a standard encoding based on a single weird source.

Co-authored-by: Laurent Pugin <[email protected]>
@ahankinson
Copy link
Contributor

Preliminary tests indicate that <divLine> may work, but it needs a bit of finessing. So we can accept this PR, but the actual implementation may change later.

@ahankinson ahankinson merged commit 6f0b050 into rism-digital:develop Sep 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants