Introduction and restructure #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Restructures the specification to follow the original "Part I" and "Part II" structures - Adds introductory prose
|
ahankinson
added
the
Type: Spec Enhancement
lpugin
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original papers, Brook and Gould clearly thought of the incipit code as being in two parts: "Part I (Preliminary Data)" and "Part II (The Notes)".
The previous version of the spec did not keep this structure, and put clef, time signature, and key signature on equal footing with the notation data. I think I know why -- the clef, key sig, and time sig each have their own MARC field, and then everything else goes in the notation field.
However, I think keeping the distinction is actually clearer: There are some things that capture the "staff definitions" (to borrow a term from MEI) which can be grouped together despite occurring in their own fields in the representations of the incipit (MARC, text, JSON, etc.)
This was made clearer in the discussions around the formalization of inline changes, where changes in clef/key/time are set apart from the notation values by a space character, clearly defining them as something "other" than the notation itself. (See: #91)
So the bulk of this PR is a restructuring to re-introduce the original distinctions in the specification made by Brook and Gould. I found the titles "Preliminary Data" and "The Notes" to be not very specific about their contents, so the new section is called "Staff Definitions" -- terminology borrowed from MEI for the same class of data.
It also contains a new introduction to the specification that attempts to provide the motivation for the new version.