Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stream): implement framework of now executor #6677

Closed
wants to merge 2 commits into from

Conversation

soundOfDestiny
Copy link
Contributor

@soundOfDestiny soundOfDestiny commented Nov 30, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

This is framework of Now executor.
Here defines interface of Now executor and builder.
Frontend part, backend part and barrier part of now executor will be based on this.

Checklist

  • I have written necessary rustdoc comments
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.

Types of user-facing changes

Please keep the types that apply to your changes, and remove those that do not apply.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.

Refer to a related PR or issue link (optional)

#6408

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #6677 (498a719) into main (2d87383) will decrease coverage by 0.09%.
The diff coverage is 61.27%.

@@            Coverage Diff             @@
##             main    #6677      +/-   ##
==========================================
- Coverage   74.07%   73.98%   -0.10%     
==========================================
  Files         989      995       +6     
  Lines      161850   162137     +287     
==========================================
+ Hits       119888   119950      +62     
- Misses      41962    42187     +225     
Flag Coverage Δ
rust 73.98% <61.27%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/error.rs 0.00% <ø> (ø)
src/common/src/catalog/schema.rs 78.12% <0.00%> (-6.34%) ⬇️
src/compute/src/server.rs 0.00% <0.00%> (ø)
src/expr/src/error.rs 25.00% <ø> (ø)
src/frontend/src/catalog/root_catalog.rs 72.76% <0.00%> (-2.52%) ⬇️
src/frontend/src/handler/drop_index.rs 59.70% <0.00%> (-5.88%) ⬇️
src/frontend/src/handler/drop_source.rs 0.00% <0.00%> (-85.15%) ⬇️
src/risedevtool/src/config.rs 0.00% <0.00%> (ø)
src/risedevtool/src/service_config.rs 0.00% <0.00%> (ø)
src/risedevtool/src/task.rs 0.00% <ø> (ø)
... and 56 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@soundOfDestiny soundOfDestiny deleted the zl_now_base branch December 2, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant