Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split catalog to smaller files #19870

Merged
merged 5 commits into from
Dec 20, 2024
Merged

refactor: split catalog to smaller files #19870

merged 5 commits into from
Dec 20, 2024

Conversation

tabVersion
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

just split the funcs into files, no logic change

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 5519 files.

Valid Invalid Ignored Fixed
2325 3 3191 0
Click to see the invalid file list
  • src/meta/src/controller/catalog/alter_op.rs
  • src/meta/src/controller/catalog/drop_op.rs
  • src/meta/src/controller/catalog/util.rs
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

src/meta/src/controller/catalog/alter_op.rs Show resolved Hide resolved
src/meta/src/controller/catalog/drop_op.rs Show resolved Hide resolved
src/meta/src/controller/catalog/util.rs Show resolved Hide resolved
@tabVersion tabVersion added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit d6341b7 Dec 20, 2024
30 of 31 checks passed
@tabVersion tabVersion deleted the tab/move-catalog branch December 20, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants